Fix StreamConsumer wakeup races #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice finding @trtt! This looks correct to me but if @duarten, @davidblewett and @fede1024 could also give it another look would be great. |
scanterog
reviewed
Aug 8, 2024
src/consumer/base_consumer.rs
Outdated
| let evname = rdsys::rd_kafka_event_name(event.ptr()); | ||
| CStr::from_ptr(evname).to_bytes() | ||
| }; | ||
| let evname = String::from_utf8(buf.to_vec()).unwrap(); |
There was a problem hiding this comment.
nit: please let's try to avoid to panic here.
There was a problem hiding this comment.
sure. I'm not even sure why I changed it in the first place
934c580
cpaika
approved these changes
Aug 29, 2024
|
I will try to review this this week. I was hopeful it would address the flaky |
mlowicki
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #665